mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Review Request 36867: Add "labels" to FrameworkInfo.
Date Tue, 28 Jul 2015 00:04:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867/
-----------------------------------------------------------

Review request for mesos, Adam B, Connor Doyle, and Niklas Nielsen.


Bugs: MESOS-2841
    https://issues.apache.org/jira/browse/MESOS-2841


Repository: mesos


Description
-------

This is intended to support frameworks that want to offer capabilities to the
rest of the cluster (e.g., storage or some arbitrary third-party service). We
want processes running in the cluster to be able to discover these capabilities;
however, we don't want to commit to a fixed set of capabilities or how those
capabilities should be represented. Hence, this commit represents this
information using freeform key-value pairs, similar to the labels mechanism
already in use elsewhere.

Note that this doesn't include a test for the scheduler failover case: I noticed
that a basically equivalent test case is in-progress for MESOS-2880
(https://reviews.apache.org/r/35797/), so I figured that once 2880 is merged, it
will be easy to update that test to check that labels are propagated correctly.

Jira: MESOS-2841


Diffs
-----

  include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba 
  src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
  src/master/master.hpp 9f27f8baa10221f7e951eb6074dbbfc87ec77f13 
  src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c 

Diff: https://reviews.apache.org/r/36867/diff/


Testing
-------

make check


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message