mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anindya Sinha" <anindya_si...@apple.com>
Subject Re: Review Request 34128: Enable different IP/Port for external access.
Date Mon, 27 Jul 2015 19:21:17 GMT


> On July 24, 2015, 9:14 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/process.cpp, line 774
> > <https://reviews.apache.org/r/34128/diff/2/?file=963212#file963212line774>
> >
> >     Why the extra variable here? This part of the code shouldn't need to change
IIUC.

This was done to address https://reviews.apache.org/r/34128/#comment134539. If I look at the
comment a little deeper know, I think I might have misunderstood it as that comment assumed
we are binding to public_ip:public_port which we are not.

I think we should keep my original change, ie. __address__ (not use address_to_bind). We bind
on libprocess_ip:libprocess_port (existing implementation), and then replace __address__.ip/port
with LIBPROCESS_ADVERTISE_IP:LIBPROCESS_ADVERTISE_PORT if set.


- Anindya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34128/#review92983
-----------------------------------------------------------


On May 18, 2015, 10:08 p.m., Anindya Sinha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34128/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 10:08 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-809
>     https://issues.apache.org/jira/browse/MESOS-809
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Expose environment variables LIBPROCESS_PUBLIC_IP and LIBPROCESS_PUBLIC_PORT as the IP
and
> port which libprocess would advertise (if set). If not set, it defaults to
> the IP and port on which it binded to.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/process.cpp e3de3cd6b536aaaf59784360aed546512dd04dc9 
> 
> Diff: https://reviews.apache.org/r/34128/diff/
> 
> 
> Testing
> -------
> 
> Testing:
>   make test
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message