mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Schlicht" <...@mesosphere.io>
Subject Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.
Date Mon, 27 Jul 2015 15:38:42 GMT


> On July 24, 2015, 2:14 p.m., Joerg Schad wrote:
> > src/slave/containerizer/fetcher.cpp, line 997
> > <https://reviews.apache.org/r/36773/diff/1/?file=1020832#file1020832line997>
> >
> >     This new behavior should be reflected in the documentation. AFAIK there are
two markdown files which would need updating..

Cache eviction is mentioned in fetcher.md and fetcher-cache-internals.md. As fetcher.md does
not describe how cache eviction is done, only that it is done, it is not needed to mention
LRU here. On the other hand it is now mentioned in fetcher-cache-internals.md, because this
file describes what is done during cache eviction.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review92895
-----------------------------------------------------------


On July 27, 2015, 5:38 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36773/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 5:38 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joerg Schad.
> 
> 
> Bugs: MESOS-3112
>     https://issues.apache.org/jira/browse/MESOS-3112
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A linked list is used to keep cache entries in LRU-to-MRU order. Each time an existing
cache entry is requested, it is moved to the back of the list. During cache eviction entries
are removed from the front of the list until enough cache space can be freed.
> 
> 
> Diffs
> -----
> 
>   docs/fetcher-cache-internals.md 327cbc3074bcc110e1250e2151dd5401ccaadb4b 
>   src/slave/containerizer/fetcher.hpp 17225072ba5c1c9a7209f2923bcf562fcb76201f 
>   src/slave/containerizer/fetcher.cpp e030deabd5e749100cbccabb256dbd4af8b2fe58 
>   src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 
> 
> Diff: https://reviews.apache.org/r/36773/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message