-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36829/#review93077
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp (line 29)
<https://reviews.apache.org/r/36829/#comment147336>
const?
3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp (line 30)
<https://reviews.apache.org/r/36829/#comment147337>
Perhaps I am missing something, but is it reasonable to assume that <iostream> will
always be included before this header?
3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp (line 32)
<https://reviews.apache.org/r/36829/#comment147338>
Ditto about <stdlib.h>.
- Artem Harutyunyan
On July 26, 2015, 2 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36829/
> -----------------------------------------------------------
>
> (Updated July 26, 2015, 2 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael
Park.
>
>
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 5c19e3ef8ba50ab007eda26b752441f076ca7ed0
> 3rdparty/libprocess/3rdparty/stout/include/stout/unimplemented.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36829/diff/
>
>
> Testing
> -------
>
> requires follow-up patch.
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
|