mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}.
Date Sun, 26 Jul 2015 20:34:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36799/#review93057
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36718, 36754, 36755, 36799]

All tests passed.

- Mesos ReviewBot


On July 26, 2015, 6:49 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36799/
> -----------------------------------------------------------
> 
> (Updated July 26, 2015, 6:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The new names better reflect the contents since the Limitation and State are for the
container.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.hpp 879e03e5bf49fab507b8d9904f944d950de18987 
>   include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 
>   src/common/protobuf_utils.hpp 5c992540e29143ed51fdd06b52dbde05e4136f58 
>   src/common/protobuf_utils.cpp bf178d2942e8f5bed3d7eff44ed5929a552ecf35 
>   src/slave/containerizer/isolator.hpp 1482b4c9fa375bdb2607bf83334b44b97024cba8 
>   src/slave/containerizer/isolator.cpp 9d2af8b42f37550a75eae52ef1f5c1a647131072 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 409a3a997a7b2c7104421f48ee1078e8fd369a2a

>   src/slave/containerizer/isolators/cgroups/cpushare.cpp ccaf1e372c0693522aed2e0aa8d680e404faf8ef

>   src/slave/containerizer/isolators/cgroups/mem.hpp d43ba6d3debfc6279a023bd28f584635eeb79dc3

>   src/slave/containerizer/isolators/cgroups/mem.cpp 70c9868dbb670278b3bb4e4322598285488851fe

>   src/slave/containerizer/isolators/cgroups/perf_event.hpp 3796b30a56799a00f1ddbec9bd20b9203d689856

>   src/slave/containerizer/isolators/cgroups/perf_event.cpp a62a4e6ca573230af17781495eae63115ef28f00

>   src/slave/containerizer/isolators/filesystem/posix.hpp 2afc572d20acb3d31d3981d99ffe6ea45ae93dff

>   src/slave/containerizer/isolators/filesystem/posix.cpp 5e5a896d9888375259a38dcc68d03dce6406a28e

>   src/slave/containerizer/isolators/filesystem/shared.hpp f6ba43a6d6d3a2afb9380f05de9edaa3fe3c5936

>   src/slave/containerizer/isolators/filesystem/shared.cpp 4694025eb9b3adad70cc1ec7541c3d3f95fec2bc

>   src/slave/containerizer/isolators/namespaces/pid.hpp 61db386b1d6f602edcba8a1fa251cfd12a534aca

>   src/slave/containerizer/isolators/namespaces/pid.cpp 29be94b96ed9a3db90c88a4b60517d78e95b7144

>   src/slave/containerizer/isolators/network/port_mapping.hpp fb9ce9c3a33d652a6e1dda3485dde0f2d914ccac

>   src/slave/containerizer/isolators/network/port_mapping.cpp 3f35782c9e0e458169777bab778178c524a58b2b

>   src/slave/containerizer/isolators/posix.hpp 58d9911fef6f57dd078c533221094f9c69489fe4

>   src/slave/containerizer/isolators/posix/disk.hpp 86aea37d0bbf5d2e5bfc32624fe084b2e73dac1a

>   src/slave/containerizer/isolators/posix/disk.cpp 845496c865a92946910a4e9dd50d05482503b7ef

>   src/slave/containerizer/launcher.hpp a19b8592f943d3a2ae0337c142f54c0ada204536 
>   src/slave/containerizer/launcher.cpp ecb33309ff0941985eebf7a94d831330076978de 
>   src/slave/containerizer/linux_launcher.hpp 28a7d35dbbbb99881486a9d63eb0aaedad15cb99

>   src/slave/containerizer/linux_launcher.cpp ed2e881f555d651ad1e5f1b62f32848ade09b424

>   src/slave/containerizer/mesos/containerizer.hpp 5155362bef9163af3fa5334be3a39b91549e1ec1

>   src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368

>   src/slave/containerizer/provisioner.hpp f7fb068ca5b0a8da1fb756411d59536ed7a1aec8 
>   src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea

>   src/tests/containerizer/isolator.hpp 8aaf88c3ea8362950e363d15cbe2b598a12f12d6 
>   src/tests/containerizer/launcher.hpp 78216e0805eadb8eb425d9d58aae1b102a7817b5 
> 
> Diff: https://reviews.apache.org/r/36799/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message