mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 36720: Add subscribe-> subscribed workflow for http frameworks
Date Sat, 25 Jul 2015 07:07:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/#review93021
-----------------------------------------------------------


Bad patch!

Reviews applied: [36733]

Failed command: ./support/apply-review.sh -n -r 36733

Error:
 2015-07-25 07:07:12 URL:https://reviews.apache.org/r/36733/diff/raw/ [58421/58421] ->
"36733.patch" [1]
error: patch failed: src/master/master.hpp:901
error: src/master/master.hpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On July 25, 2015, 7 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36720/
> -----------------------------------------------------------
> 
> (Updated July 25, 2015, 7 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2294
>     https://issues.apache.org/jira/browse/MESOS-2294
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Split review out of r36318. This change adds the functionality of making a http call
for subscribe and the master responding with a subscribed event on the persistent stream.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 3a1598fad4db03e5f62fd4a6bd26b2bedeee4070 
>   src/master/master.hpp 827d0d599912b2936beb9615610f627f6c9a2d43 
>   src/master/master.cpp 613a011e205611702921179b6c436d62447e2dca 
>   src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac 
> 
> Diff: https://reviews.apache.org/r/36720/diff/
> 
> 
> Testing
> -------
> 
> make check + test.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message