mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 36663: Added ip_address field to MasterInfo
Date Sat, 25 Jul 2015 00:36:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/
-----------------------------------------------------------

(Updated July 25, 2015, 12:36 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
-------

removed the test - will be part of another review (it causes tests to hang in ZK)


Bugs: MESOS-2736
    https://issues.apache.org/jira/browse/MESOS-2736


Repository: mesos


Description
-------

Added address field to MasterInfo
    
    As part of the new HTTP API and the need to
    provide a better interface for clients that
    do not integrate libmesos, we provide the IP
    address of the Leader Master in the information
    that gets serialized (in JSON) to ZooKeeper.
    
    This will eventually supersede the `ip`, `port`
    and `hostname` fields that are currently in
    MasterInfo an which cannot fully support IPv6
    addresses.
    
    Jira: MESOS-2736
    
    Review: https://reviews.apache.org/r/36663


Diffs (updated)
-----

  CHANGELOG 1a8649d00f3bcc792a75c11dedeb42a667e2ce88 
  include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a 
  src/common/protobuf_utils.cpp d900707ae64ad92c0c0ddc2996324b61121c8594 
  src/master/master.cpp 7796630a93705bd62157e98e1e4855c68ea7cd0a 
  src/tests/master_contender_detector_tests.cpp d7a3b46b2e437818631064ae34317e49c9aa3748 

Diff: https://reviews.apache.org/r/36663/diff/


Testing
-------

make check
(also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the information serialized
to ZK is readable and as expected).

Also ran 2x 0.23 master builds against a 0.24 one with this patch applied; getting both versions
in turn to be Leader, and also ran a 0.23 Slave with a 0.24 Leader, and they all recognized
each other.


Thanks,

Marco Massenzio


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message