> On July 24, 2015, 3:58 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 1015
> > <https://reviews.apache.org/r/36757/diff/1-3/?file=1020505#file1020505line1015>
> >
> > s/{}/None()
> > s/payload/None()
> >
> > You should be able to do without setting headers and body here.
>
> Jojy Varghese wrote:
> It will work but the test here is for having "some" payload and https not crapping
out for actual POST data.
I see, my bad. Mind atleast removing the default headers here ?
> On July 24, 2015, 3:58 p.m., Anand Mazumdar wrote:
> > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 989
> > <https://reviews.apache.org/r/36757/diff/1-3/?file=1020505#file1020505line989>
> >
> > AWAIT_EXPECT_RESPONSE_STATUS_EQ(OK().status, response);
>
> Jojy Varghese wrote:
> The pattern "ASSERT_EQ(http::statuses[200], response.get().status)" is the one adopted
in http_tests.cpp. Not sure if I want to have a new pattern for https tests.
There are not many places left in our code that still use this old style. ( All the remaining
ones left would eventually get cleaned up ).
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36757/#review92921
-----------------------------------------------------------
On July 24, 2015, 5:49 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36757/
> -----------------------------------------------------------
>
> (Updated July 24, 2015, 5:49 p.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Timothy Chen.
>
>
> Bugs: MESOS-3093
> https://issues.apache.org/jira/browse/MESOS-3093
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Current http implementation lacks a https interface. This change exposes
> SSL socket for "https" URL scheme.
>
> JIRA: MESOS-3093
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/http.cpp d1685799f4c53e067d0812e037e171324ee7195f
> 3rdparty/libprocess/src/tests/ssl_tests.cpp 2fe50601615b0bee57bd3e05dc9c932f93ca7477
>
> Diff: https://reviews.apache.org/r/36757/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jojy Varghese
>
>
|