mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 36741: Add small fixes allowing CMake to build Process lib tests on OS X 10.10
Date Fri, 24 Jul 2015 17:14:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36741/#review92930
-----------------------------------------------------------

Ship it!


Ship It!

- Artem Harutyunyan


On July 23, 2015, 4:40 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36741/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 4:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There are two things that have to change in the current CMake build
> solution in order to work on OS X 10.10:
>   * librt (which holds the POSIX.1b Realtime Extensions interfaces in
>     Linux, including things like async I/O and memory-mapped files, etc.)
>     does not exist on OS X, and does not need to be linked
>   * The version of GTest attempts to find std::tr1::tuple, which is not
>     available on OS X 10.10. Like we have done in autotools (see[1] and
>     also configure.ac) we simply define `GTEST_USE_OWN_TR1_TUPLE` when
>     we're compiling on OS X.
> 
> [1] https://mail-archives.apache.org/mod_mbox/mesos-dev/201403.mbox/%3C20140306223933.2625.25724@reviews.apache.org%3E
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 851ab94e4c0f901520c9a4d209f5b9c928116d3c

>   3rdparty/libprocess/cmake/ProcessConfigure.cmake d6cdd05e281f23f0a57809d3798b5766fb2e9aa6

>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 082489ca4a31843886f764105e70e6af9779ca11

> 
> Diff: https://reviews.apache.org/r/36741/diff/
> 
> 
> Testing
> -------
> 
> Tested fixes on OS X 10.10 and Ubuntu 14 boxes.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message