> On July 20, 2015, 4:42 p.m., haosdent huang wrote:
> > src/tests/fetcher_tests.cpp, line 297
> > <https://reviews.apache.org/r/36501/diff/6/?file=1015170#file1015170line297>
> >
> > According https://github.com/apache/mesos/blob/master/docs/mesos-c%2B%2B-style-guide.md#function-definitioninvocation
You indent is not correct here. Maybe need change to like this
> >
> > ```
> > process::http::URL url(
> > "http",
> > process.self().address.ip,
> > process.self().address.port,
> > "/help");
> > ```
> >
> > But I perfer chang it like this
> > ```
> > const network::Address& address = process.self().address;
> > process::http::URL url("http", address.ip, address.port, "/help");
> > ```
> >
> > Or add `using URL` like this
> > ```
> > using process::Future;
> >
> > using process::http::URL; (Left a blank below and after process::Future)
> > ```
> >
> > and then
> > ```
> > const network::Address& address = process.self().address;
> > URL url("http", address.ip, address.port, "/help");
> > ```
>
> Bernd Mathiske wrote:
> I agree. Thanks, haosdent!
I address the comments by option 2. Reguarding "using URL", it'll compile because there's
also mesos::URL here. But mesos::URL is a protobuf class, it will make code more complex.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92270
-----------------------------------------------------------
On July 18, 2015, 9:47 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36501/
> -----------------------------------------------------------
>
> (Updated July 18, 2015, 9:47 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-3023
> https://issues.apache.org/jira/browse/MESOS-3023
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix for MESOS-3023 (Factoring out the pattern for URL generation)
>
>
> Diffs
> -----
>
> src/tests/fetcher_tests.cpp ae10c42
>
> Diff: https://reviews.apache.org/r/36501/diff/
>
>
> Testing
> -------
>
> 1. Build successfully in Linux
> 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest
>
>
> Thanks,
>
> Klaus Ma
>
>
|