mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <kl...@cguru.net>
Subject Re: Review Request 36501: MESOS-3023
Date Fri, 24 Jul 2015 09:08:53 GMT


> On July 20, 2015, 4:42 p.m., haosdent huang wrote:
> >
> 
> haosdent huang wrote:
>     Its a bit difficult to follow the mesos style guide at first. Maybe the committer
could help you reformat it when summit @klausma1982 . :-)

Thanks very much for your patience; yes, it tooks time for me to swith between different code
style :).


> On July 20, 2015, 4:42 p.m., haosdent huang wrote:
> > src/tests/fetcher_tests.cpp, line 314
> > <https://reviews.apache.org/r/36501/diff/6/?file=1015170#file1015170line314>
> >
> >     It would be better to add ```#include <stout/stringify.hpp>``` after ```#include
<stout/protobuf.hpp>```

stout/stringify.hpp has been included; so did not add it.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92270
-----------------------------------------------------------


On July 18, 2015, 9:47 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36501/
> -----------------------------------------------------------
> 
> (Updated July 18, 2015, 9:47 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3023
>     https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix for MESOS-3023 (Factoring out the pattern for URL generation)
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_tests.cpp ae10c42 
> 
> Diff: https://reviews.apache.org/r/36501/diff/
> 
> 
> Testing
> -------
> 
> 1. Build successfully in Linux
> 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message