mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 36761: Added tests for unset framework pid in the slave.
Date Fri, 24 Jul 2015 03:41:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36761/#review92866
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36759, 36760, 36761]

All tests passed.

- Mesos ReviewBot


On July 24, 2015, 1:45 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36761/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 1:45 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3132
>     https://issues.apache.org/jira/browse/MESOS-3132
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since we do not yet have HTTP schedulers, this adds tests
> that spoof empty pids coming from the master.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 69134e1c2664ca24a1ecd80a662c841311104a6a 
>   src/tests/slave_tests.cpp e1390ad84b0003052681600deb9ca518defc0970 
> 
> Diff: https://reviews.apache.org/r/36761/diff/
> 
> 
> Testing
> -------
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message