mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.
Date Fri, 24 Jul 2015 01:58:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36755/#review92856
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36718, 36754, 36755]

All tests passed.

- Mesos ReviewBot


On July 24, 2015, 12:20 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36755/
> -----------------------------------------------------------
> 
> (Updated July 24, 2015, 12:20 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3133
>     https://issues.apache.org/jira/browse/MESOS-3133
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Append the environment variables returned by Isolator::prepare() to the
> list of environment variables being passed to the executor. Added a test
> to verify that the executor is launched with the said environment
> variables.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 609620c4322e41562597ee682b311cd320bca6d2

>   src/tests/containerizer_tests.cpp 88c46e7214f4d92b7d6a9b433a3a0497681dc6db 
> 
> Diff: https://reviews.apache.org/r/36755/diff/
> 
> 
> Testing
> -------
> 
> make check with an added test.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message