mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 36663: Added ip_address field to MasterInfo
Date Thu, 23 Jul 2015 23:51:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36663/#review92834
-----------------------------------------------------------



src/master/master.cpp (lines 344 - 346)
<https://reviews.apache.org/r/36663/#comment147078>

    Move this up to #319.



src/tests/master_tests.cpp (line 1019)
<https://reviews.apache.org/r/36663/#comment147080>

    why not compare ip with master.get().address.ip() ?
    
    mesos doesn't necessarily bind to 127.0.0.1 as you might've seen in reviewbot failure.



src/tests/master_tests.cpp (line 1021)
<https://reviews.apache.org/r/36663/#comment147082>

    ditto. doesn't necessarily map to "localhost".



src/tests/master_tests.cpp (line 1022)
<https://reviews.apache.org/r/36663/#comment147083>

    This test is testing the createMasterInfo() method which is not used in production. Can
you also write a test with ZK in play? That is going to test the changes you made in master.cpp.


- Vinod Kone


On July 23, 2015, 9:46 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36663/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 9:46 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-2736
>     https://issues.apache.org/jira/browse/MESOS-2736
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added address field to MasterInfo
>     
>     As part of the new HTTP API and the need to
>     provide a better interface for clients that
>     do not integrate libmesos, we provide the IP
>     address of the Leader Master in the information
>     that gets serialized (in JSON) to ZooKeeper.
>     
>     This will eventually supersede the `ip`, `port`
>     and `hostname` fields that are currently in
>     MasterInfo an which cannot fully support IPv6
>     addresses.
>     
>     Jira: MESOS-2736
>     
>     Review: https://reviews.apache.org/r/36663
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886 
>   src/common/protobuf_utils.cpp e0f82b53f5e106bbf4e21d6ac946df0fae821882 
>   src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 
>   src/tests/master_tests.cpp 826f276317da2507cdf99b2f2e21a147444469d8 
> 
> Diff: https://reviews.apache.org/r/36663/diff/
> 
> 
> Testing
> -------
> 
> make check
> (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the information
serialized to ZK is readable and as expected).
> 
> Also ran 2x 0.23 master builds against a 0.24 one with this patch applied; getting both
versions in turn to be Leader, and also ran a 0.23 Slave with a 0.24 Leader, and they all
recognized each other.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message