mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 36743: Cause CMake to fail and return error code if C++11 not supported
Date Thu, 23 Jul 2015 23:40:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36743/
-----------------------------------------------------------

(Updated July 23, 2015, 11:40 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van Remoortere.


Repository: mesos


Description
-------

The current CMake build system will print a warning that your compiler
doesn't support C++11, but still return exit code 0. (It also returns a
garbled error message.)

This commit will cause it to hard-fail the config step, and return an
error code. It will also generate a non-garbled error message.


Diffs
-----

  cmake/MesosConfigure.cmake 16b72f1aa135666174cf10d73d52443d51529c6c 

Diff: https://reviews.apache.org/r/36743/diff/


Testing
-------

Tested with gcc/g++ 4.4 on Ubuntu 14. Clearly fails.


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message