mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 36733: Moved framework struct in master to end of file
Date Thu, 23 Jul 2015 19:25:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36733/#review92792
-----------------------------------------------------------


Is there anything preventing you from using forward declarations?  Or just implementing the
templated send function after the Master has been defined?

i.e. 
```
struct Framework {
  ...
  template <typename Message>
  void send(const Message& message);
  ...
}

class Master { ... }

template <typename Message>
void Framework::send(const Message& message) {
  ...
}
```

- Joseph Wu


On July 23, 2015, 10:26 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36733/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 10:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved framework struct to end of file since the framework struct needs to know about
the implementation of master for invoking templated send(...). Needed for r36318.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec 
> 
> Diff: https://reviews.apache.org/r/36733/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message