mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.
Date Thu, 23 Jul 2015 18:24:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36708/#review92784
-----------------------------------------------------------

Ship it!



include/mesos/scheduler/scheduler.proto (lines 46 - 52)
<https://reviews.apache.org/r/36708/#comment147024>

    "does not receive heartbeats, or any other events, for an extended"?
    
    Just thinking that we don't care about heartbeats when there are lots of events flowing
(and this may skew the scheduler's perception of time between heartbeats).


- Ben Mahler


On July 23, 2015, 12:23 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36708/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 12:23 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
> 
> 
> Bugs: MESOS-3131
>     https://issues.apache.org/jira/browse/MESOS-3131
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is to deal with network partition and also making sure that network intermediaries
do not close the persistent connection between scheduler and master.
> 
> Will add the code in the master once it can speak HTTP.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto e2ca8e5cfb3d6405bf7be93d621743ce48c6c7e6 
> 
> Diff: https://reviews.apache.org/r/36708/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message