-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36677/#review92627
-----------------------------------------------------------
Ship it!
Nice test!
3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp (lines 118 - 119)
<https://reviews.apache.org/r/36677/#comment146921>
Can you fix the indentation:
```
return Error("Failed ..." +
numify.error());
```
or
```
return Error(
"Failed"... + ...
numify.error()
```
3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp (line 129)
<https://reviews.apache.org/r/36677/#comment147018>
Maybe do the following which is more explicit?
```
records.push_back(decode_(""));
```
3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp (line 130)
<https://reviews.apache.org/r/36677/#comment147019>
Not needed?
- Jie Yu
On July 22, 2015, 11:24 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36677/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 11:24 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu.
>
>
> Bugs: MESOS-3067
> https://issues.apache.org/jira/browse/MESOS-3067
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Note that most "Record-IO" encodings are used for file I/O
> and consequently use a fixed-size header to encode the record
> length. However, decoding a base-10 integer is more
> straightforward to implement in most languages, and so this
> was chosen instead. (Note that the Twitter streaming API
> uses the same technique for portability).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 2394b95462182273464f0847f416ad83c3b64485
> 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 8c75f6b28c18596018eaefe427b238424aae2fd9
> 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36677/diff/
>
>
> Testing
> -------
>
> Added tests.
>
>
> Thanks,
>
> Ben Mahler
>
>
|