mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 36318: Refactored framework struct in master to support http frameworks
Date Thu, 23 Jul 2015 17:29:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36318/
-----------------------------------------------------------

(Updated July 23, 2015, 5:29 p.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, Isabel Jimenez, Marco Massenzio, and
Vinod Kone.


Changes
-------

Removed extra line-break + added the dependent review for moving struct to end of file (r36733)


Bugs: MESOS-2294
    https://issues.apache.org/jira/browse/MESOS-2294


Repository: mesos


Description
-------

This change refactors the framework struct in master to introduce support for
http frameworks.
- pid becomes a optional field now in the framework struct.
- added optional fields for supporting http frameworks to the framework struct
- added a subcribe(...) method that
  registerFramework(...)/subscribeHttpFramework(...) call into. Similar
  functionality needs to be added for reregister to call into subscribe too.


Diffs (updated)
-----

  src/common/protobuf_utils.hpp 2e827a0923de83d5cf853a12435b451cc7c55891 
  src/common/protobuf_utils.cpp e0f82b53f5e106bbf4e21d6ac946df0fae821882 
  src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 
  src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec 
  src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 

Diff: https://reviews.apache.org/r/36318/diff/


Testing
-------

make check + tests now go in a separate patch now.


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message