mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <>
Subject Re: Review Request 36318: Refactored framework struct in master to support http frameworks
Date Thu, 23 Jul 2015 04:25:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 23, 2015, 4:25 a.m.)

Review request for mesos, Benjamin Hindman, Ben Mahler, Isabel Jimenez, Marco Massenzio, and
Vinod Kone.


Addressed BenM's comments to refactor the framework struct and made pid options ( see description
for a list of changes ), Also splitted the original patch into smaller chunks.

Summary (updated)

Refactored framework struct in master to support http frameworks

Bugs: MESOS-2294

Repository: mesos

Description (updated)

This change refactors the framework struct in master to introduce support for
http frameworks.
- pid becomes a optional field now in the framework struct.
- added optional fields for supporting http frameworks to the framework struct
- added a subcribe(...) method that
  registerFramework(...)/subscribeHttpFramework(...) call into. Similar
  functionality needs to be added for reregister to call into subscribe too.

Apologies for the extended diff ( I moved the framework struct to the end of
the file as it used some functionality from the master class. The method was
templated and had to implemented in the header file )

Diffs (updated)

  src/common/protobuf_utils.hpp 2e827a0923de83d5cf853a12435b451cc7c55891 
  src/common/protobuf_utils.cpp e0f82b53f5e106bbf4e21d6ac946df0fae821882 
  src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 
  src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec 
  src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 


Testing (updated)

make check + tests now go in a separate patch now.


Anand Mazumdar

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message