mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 36717: Add missing include in cpp file.
Date Thu, 23 Jul 2015 03:06:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36717/#review92710
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36717]

All tests passed.

- Mesos ReviewBot


On July 23, 2015, 2:25 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36717/
> -----------------------------------------------------------
> 
> (Updated July 23, 2015, 2:25 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2294
>     https://issues.apache.org/jira/browse/MESOS-2294
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Looks like we never used to include the corresponding header file :-)
> 
> Added the file and fixed the trivial compilation error as a result of it ( involving
default arguments in implementation )
> 
> 
> Diffs
> -----
> 
>   src/common/protobuf_utils.cpp e0f82b53f5e106bbf4e21d6ac946df0fae821882 
> 
> Diff: https://reviews.apache.org/r/36717/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message