mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 36677: Introduced 'recordio' encoding facilities to stout.
Date Wed, 22 Jul 2015 06:09:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36677/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu.


Bugs: MESOS-3067
    https://issues.apache.org/jira/browse/MESOS-3067


Repository: mesos


Description
-------

Note that most "Record-IO" encodings are used for file I/O
and consequently use a fixed-size header to encode the record
length. However, decoding a base-10 integer is more
straightforward to implement in most languages, and so this
was chosen instead. (Note that the Twitter streaming API
uses the same technique for portability).


Diffs
-----

  3rdparty/libprocess/3rdparty/Makefile.am 856c2b289451fd404b97285b825e72913feb2f04 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 2394b95462182273464f0847f416ad83c3b64485

  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 8c75f6b28c18596018eaefe427b238424aae2fd9

  3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/36677/diff/


Testing
-------

Added tests.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message