mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.
Date Tue, 21 Jul 2015 22:59:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36656/#review92492
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 673)
<https://reviews.apache.org/r/36656/#comment146704>

    Since it's used in several places, will it make sense to have a helper function that returns
a vector with protocols?



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 675)
<https://reviews.apache.org/r/36656/#comment146699>

    s/protocol/protocols/



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 807)
<https://reviews.apache.org/r/36656/#comment146700>

    ditto.



3rdparty/libprocess/src/tests/ssl_tests.cpp (line 865)
<https://reviews.apache.org/r/36656/#comment146701>

    ditto.


- Artem Harutyunyan


On July 21, 2015, 3:51 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36656/
> -----------------------------------------------------------
> 
> (Updated July 21, 2015, 3:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Michael Park.
> 
> 
> Bugs: MESOS-3121
>     https://issues.apache.org/jira/browse/MESOS-3121
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/openssl.hpp 3f8d351589f8bb26c886da12c53b5e02a242376a 
>   3rdparty/libprocess/src/openssl.cpp 6aa2a4db8d64011d0fde6ff0cf4b144c41949d39 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 2fe50601615b0bee57bd3e05dc9c932f93ca7477

> 
> Diff: https://reviews.apache.org/r/36656/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message