mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
Date Mon, 20 Jul 2015 21:00:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
-----------------------------------------------------------

(Updated July 20, 2015, 11 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Kapil Arya, and Till Toenshoff.


Changes
-------

Till's review. Rebase


Bugs: MESOS-2946
    https://issues.apache.org/jira/browse/MESOS-2946


Repository: mesos


Description
-------

Splits and updates the original declaration of the `Authorizer` into its interface and a default
implementation, the `LocalAuthorizer`.

Following the pattern of the modularized `Authenticator`, it generates a default constructor
which is required when writing a `TYPED_TEST` in
a follow up patch. Additionally, an initialize method has been added, needed for passing in
the current ACL definitions as provided via
flags.

Other changes are just updates to allow for compilation.


Diffs (updated)
-----

  include/mesos/authorizer/authorizer.hpp PRE-CREATION 
  include/mesos/authorizer/authorizer.proto PRE-CREATION 
  include/mesos/mesos.proto cb24125a3f05e0d38fb22e481a15ceb21f882d27 
  include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e 
  src/Makefile.am e2cbd1524f25b3e3a9419af6bdf8cc6e5022a784 
  src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f 
  src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc 
  src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 
  src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 
  src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff 
  src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f 
  src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 
  src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 
  src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec 
  src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 
  src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 
  src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b 
  src/tests/mesos.hpp 23d9841c7cfb16abef89a53d29a256a2c5e94b52 
  src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 

Diff: https://reviews.apache.org/r/36048/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message