mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 36488: Added oversubscription user doc.
Date Fri, 17 Jul 2015 22:04:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36488/#review92132
-----------------------------------------------------------

Ship it!


LGTM! Thanks Niklas!


docs/oversubscription.md (line 35)
<https://reviews.apache.org/r/36488/#comment146091>

    When the latest estimate is different from the previous estimate.



docs/oversubscription.md (line 47)
<https://reviews.apache.org/r/36488/#comment146092>

    launch tasks



docs/oversubscription.md (lines 194 - 197)
<https://reviews.apache.org/r/36488/#comment146093>

    Could you please align the text at 80 char width? Please do a sweep in this file. Thanks!


- Jie Yu


On July 17, 2015, 9:27 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36488/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 9:27 p.m.)
> 
> 
> Review request for mesos, Adam B and Jie Yu.
> 
> 
> Bugs: MESOS-3033
>     https://issues.apache.org/jira/browse/MESOS-3033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added first draft of oversubscription user doc
> 
> 
> Diffs
> -----
> 
>   docs/images/oversubscription-overview.jpg PRE-CREATION 
>   docs/oversubscription.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36488/diff/
> 
> 
> Testing
> -------
> 
> Rendered at: https://github.com/nqn/mesos/blob/niklas/oversubscription-user-doc/docs/oversubscription.md
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message