mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 36501: MESOS-3023
Date Fri, 17 Jul 2015 14:20:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review92082
-----------------------------------------------------------

Ship it!


Ship It!


src/tests/fetcher_tests.cpp (line 22)
<https://reviews.apache.org/r/36501/#comment146021>

    Need sort it lexicographically.
    
    ```
    #include <sstream>
    #include <string>



src/tests/fetcher_tests.cpp (line 319)
<https://reviews.apache.org/r/36501/#comment146022>

    Not need use urlStream and import sstream here because we have stringify.hpp. Just need
    
    ```
    stringify(url)
    ```


- haosdent huang


On July 17, 2015, 2:06 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36501/
> -----------------------------------------------------------
> 
> (Updated July 17, 2015, 2:06 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3023
>     https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix for MESOS-3023 (Factoring out the pattern for URL generation)
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_tests.cpp ae10c42 
> 
> Diff: https://reviews.apache.org/r/36501/diff/
> 
> 
> Testing
> -------
> 
> 1. Build successfully in Linux
> 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message