mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Schlicht" <...@mesosphere.io>
Subject Re: Review Request 36547: Fixed fetcher failing for FTP URIs.
Date Fri, 17 Jul 2015 08:28:09 GMT


> On July 17, 2015, 4:59 a.m., Adam B wrote:
> > src/launcher/fetcher.cpp, lines 127-128
> > <https://reviews.apache.org/r/36547/diff/3/?file=1013405#file1013405line127>
> >
> >     Why not just check for any 2xx code then? Aren't they all successful in one
way or another?

HTTP can return 206, which means that only a part of the content has been (successfully) transferred.
Therefore we should really check for the designated return codes that indicate a successful
transfer of a whole resource.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36547/#review92015
-----------------------------------------------------------


On July 16, 2015, 6:55 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36547/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 6:55 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joerg Schad.
> 
> 
> Bugs: MESOS-3060
>     https://issues.apache.org/jira/browse/MESOS-3060
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The response code for successful FTP file transfers is 226, while it is 200 for HTTP.
The fetcher has been changed to check for a response code of 226 for FTP URIs.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 8aee4901ec1289f43b5fa6b830c3488815ec24cd 
> 
> Diff: https://reviews.apache.org/r/36547/diff/
> 
> 
> Testing
> -------
> 
> make check & external FTP server test.
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message