mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 36497: Implemented the SUBSCRIBE Event handler in the scheduler driver.
Date Fri, 17 Jul 2015 01:36:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36497/
-----------------------------------------------------------

(Updated July 17, 2015, 1:36 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Split apart the test.


Bugs: MESOS-2910
    https://issues.apache.org/jira/browse/MESOS-2910


Repository: mesos


Description
-------

This one is non-trivial, note that we follow MESOS-786 with the exception of the 3rd case,
since it is not possible and schedulers could not have possibly relied on getting registered
instead of re-registered in that case.

We now need to store the MasterInfo coming from the detector, as it is not provided in Event.


Diffs (updated)
-----

  src/sched/sched.cpp 839fcbf0169fecf74fb17cab94fe4d35a1e20a10 
  src/tests/scheduler_event_call_tests.cpp cf6aa19a644580ff9d805e919763e9342d72677f 

Diff: https://reviews.apache.org/r/36497/diff/


Testing
-------

Added a test.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message