mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 36465: Updated scheduler driver to send REVIVE call.
Date Fri, 17 Jul 2015 01:26:58 GMT


> On July 15, 2015, 5:58 p.m., Ben Mahler wrote:
> > src/sched/sched.cpp, line 1029
> > <https://reviews.apache.org/r/36465/diff/1/?file=1010283#file1010283line1029>
> >
> >     newline before setting the type, like your other reviews?

i'm doing new line after setting type. i'll make sure it's consistent.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36465/#review91765
-----------------------------------------------------------


On July 14, 2015, midnight, Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36465/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, midnight)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2913
>     https://issues.apache.org/jira/browse/MESOS-2913
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d 
> 
> Diff: https://reviews.apache.org/r/36465/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> (NOTE: There is already an existing test that tests the revive workflow, but it didn't
need any update)
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message