mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 36488: Added oversubscription user doc.
Date Thu, 16 Jul 2015 23:52:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36488/#review91988
-----------------------------------------------------------


Looks good Nik!


docs/oversubscription.md (line 6)
<https://reviews.apache.org/r/36488/#comment145772>

    for majority of the time



docs/oversubscription.md (line 8)
<https://reviews.apache.org/r/36488/#comment145773>

    we can oversubscribe unallocated resources as well. So probably say
    
    ```
    Oversubscription takes advantage of temporarily unused resources to ...
    ```



docs/oversubscription.md (line 28)
<https://reviews.apache.org/r/36488/#comment145765>

    s/resource slack/resource usage slack/
    
    and also allocation slack?



docs/oversubscription.md (lines 30 - 31)
<https://reviews.apache.org/r/36488/#comment145767>

    I thought we use a pull model eventually. So maybe:
    
    ```
    The slave keeps polling estimates from the resource estimator and tracks the latest estimate.
    ```



docs/oversubscription.md (lines 33 - 34)
<https://reviews.apache.org/r/36488/#comment145764>

    The slave only send the message to the master if there's a change to the previous estimate.



docs/oversubscription.md (line 39)
<https://reviews.apache.org/r/36488/#comment145768>

    The resource is revocable (not the offer).
    
    ```
    and marks those resources as `revocable`.
    ```



docs/oversubscription.md (line 40)
<https://reviews.apache.org/r/36488/#comment145769>

    up to the resource estimator to determine which types...



docs/oversubscription.md (line 46)
<https://reviews.apache.org/r/36488/#comment145770>

    Again, it's the resource that's revocable, not the offer.



docs/oversubscription.md (line 49)
<https://reviews.apache.org/r/36488/#comment145771>

    revocable resources.



docs/oversubscription.md (lines 55 - 58)
<https://reviews.apache.org/r/36488/#comment145774>

    I think it's worthwhile to mention that if any resource used by a task/executor is revocable,
the whole container is treated as a revocable container (meaning can be killed or throttled).



docs/oversubscription.md (line 69)
<https://reviews.apache.org/r/36488/#comment145776>

    Frameworks planning to use oversubscribed resources need to register ...



docs/oversubscription.md (line 80)
<https://reviews.apache.org/r/36488/#comment145777>

    I would say:
    
    ```
    , the framework will start to receive revocable resources in offers.
    ```



docs/oversubscription.md (line 84)
<https://reviews.apache.org/r/36488/#comment145778>

    See below for instructions how to configure Mesos for oversubscription.



docs/oversubscription.md (line 86)
<https://reviews.apache.org/r/36488/#comment145779>

    Launching tasks using revocable resources.



docs/oversubscription.md (line 88)
<https://reviews.apache.org/r/36488/#comment145780>

    This is not true currently. Revocable resources and regular resources will be sent in
the same offer.



docs/oversubscription.md (line 95)
<https://reviews.apache.org/r/36488/#comment145781>

    Again, currently, we don't split offers. So you may want to use an example that has one
offer but mixed type of resources.



docs/oversubscription.md (line 148)
<https://reviews.apache.org/r/36488/#comment145784>

    with fixed amount of resources.



docs/oversubscription.md (line 288)
<https://reviews.apache.org/r/36488/#comment145792>

    Maybe you want to also document how to configure the fixed resource estimator? It's configured
through modules, but shipped with Mesos?
    
    ```
    --resource_estimator="org_apache_mesos_FixedResourceEstimator"
    
    --modules="libraries {
      file: "/usr/local/lib64/libfixed_resource_estimator.so"
      modules {
        name: "org_apache_mesos_FixedResourceEstimator"
        parameters {
          key: "resources"
          value: "cpus:14"
        }
      }
    }
    
    --
    ```


- Jie Yu


On July 16, 2015, 10:39 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36488/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 10:39 p.m.)
> 
> 
> Review request for mesos, Adam B and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added first draft of oversubscription user doc
> 
> 
> Diffs
> -----
> 
>   docs/images/oversubscription-overview.jpg PRE-CREATION 
>   docs/oversubscription.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36488/diff/
> 
> 
> Testing
> -------
> 
> Rendered at: https://github.com/nqn/mesos/blob/niklas/oversubscription-user-doc/docs/oversubscription.md
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message