mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 36560: Made Subscribe.force optional in the Call protobuf.
Date Thu, 16 Jul 2015 22:04:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36560/#review91971
-----------------------------------------------------------

Ship it!



include/mesos/scheduler/scheduler.proto (lines 175 - 186)
<https://reviews.apache.org/r/36560/#comment145746>

    Hm.. this seems more confusing, why not just say in the beginning that this is only relevant
for frameworks that have been assigned an ID?
    
    e.g.
    
    // If frameowrk_info.id is present, 'force' tells the master ...


- Ben Mahler


On July 16, 2015, 9:48 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36560/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 9:48 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3055
>     https://issues.apache.org/jira/browse/MESOS-3055
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made 'force' optional because it doesn't make sense when subscribing without an id.
> 
> 
> Diffs
> -----
> 
>   include/mesos/scheduler/scheduler.proto a027da255563c620fa3d7355ad47aa16d2264f77 
>   src/examples/event_call_framework.cpp 17fdcac44c0a51293a318ef5184f4d48a461abd9 
>   src/tests/scheduler_tests.cpp 946fa8245d8ab35e04bad642d69114caf0ccf6a9 
> 
> Diff: https://reviews.apache.org/r/36560/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message