mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.
Date Thu, 16 Jul 2015 15:04:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35983/#review91890
-----------------------------------------------------------



src/master/http.cpp (line 1291)
<https://reviews.apache.org/r/35983/#comment145599>

    As in https://reviews.apache.org/r/35702/, I suggest we extract validation into a separate
function.



src/master/http.cpp (lines 1325 - 1332)
<https://reviews.apache.org/r/35983/#comment145600>

    Why do we need to recover resources for unreserve?


- Alexander Rukletsov


On June 28, 2015, 8:37 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35983/
> -----------------------------------------------------------
> 
> (Updated June 28, 2015, 8:37 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris Van Remoortere,
and Vinod Kone.
> 
> 
> Bugs: MESOS-2600
>     https://issues.apache.org/jira/browse/MESOS-2600
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
>   src/master/master.cpp 0782b543b451921d2240958c7ef612a9e30972df 
> 
> Diff: https://reviews.apache.org/r/35983/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message