mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <kl...@cguru.net>
Subject Re: Review Request 36501: MESOS-3023
Date Thu, 16 Jul 2015 04:42:31 GMT


> On July 15, 2015, 9:19 p.m., Joseph Wu wrote:
> > src/tests/utils.hpp, line 55
> > <https://reviews.apache.org/r/36501/diff/1/?file=1012134#file1012134line55>
> >
> >     * Tab size = 2 spaces.
> >     * Parameters are indented by 4 spaces.
> >     * Comments start with a capital letter and end with a period.
> >     * Logical blocks have the opening "{" on the same line.

Thanks very much for your input :). The code diff has been updated.


- Klaus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501/#review91823
-----------------------------------------------------------


On July 16, 2015, 4:41 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36501/
> -----------------------------------------------------------
> 
> (Updated July 16, 2015, 4:41 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3023
>     https://issues.apache.org/jira/browse/MESOS-3023
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix for MESOS-3023 (Factoring out the pattern for URL generation)
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_tests.cpp ae10c42 
>   src/tests/utils.hpp f2eed2e 
> 
> Diff: https://reviews.apache.org/r/36501/diff/
> 
> 
> Testing
> -------
> 
> 1. Build successfully in Linux
> 2. Test passed by src/mesos-tests --gtest_filter=FetcherTest.OSNetUriTest
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message