mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 36469: Updated scheduler driver to send MESSAGE call.
Date Wed, 15 Jul 2015 17:58:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36469/#review91770
-----------------------------------------------------------

Ship it!



src/sched/sched.cpp (line 1132)
<https://reviews.apache.org/r/36469/#comment145414>

    Ditto newline comment from other reviews.



src/tests/fault_tolerance_tests.cpp (line 1265)
<https://reviews.apache.org/r/36469/#comment145418>

    Did you want to expect that the message is sent to through the master using call, since
it looks like no offers go to the second scheduler?



src/tests/fault_tolerance_tests.cpp (lines 1313 - 1315)
<https://reviews.apache.org/r/36469/#comment145415>

    We don't need to worry about gcc 4.1.* anymore, you can assign now on the same line :)


- Ben Mahler


On July 14, 2015, 12:30 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36469/
> -----------------------------------------------------------
> 
> (Updated July 14, 2015, 12:30 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2913
>     https://issues.apache.org/jira/browse/MESOS-2913
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d 
>   src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e 
> 
> Diff: https://reviews.apache.org/r/36469/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message