mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 36461: Added FutureMessageType, DropMessagesType and ExpectNoFutureMessagesType.
Date Wed, 15 Jul 2015 17:29:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36461/#review91757
-----------------------------------------------------------


It looks like this could benefit from a bit of documentation that mentions the protobuf ["union
technique"](https://developers.google.com/protocol-buffers/docs/techniques#union).


3rdparty/libprocess/include/process/gmock.hpp (line 319)
<https://reviews.apache.org/r/36461/#comment145380>

    Anything preventing s/t/type/ ?
    
    Type in this context is a bit confusing since it sounds like the message type.
    
    Can we call this something like 'UnionMessageMatcher' and avoid using the overloaded word
"type"?



3rdparty/libprocess/include/process/gmock.hpp (line 322)
<https://reviews.apache.org/r/36461/#comment145381>

    Anything preventing s/n/message/?


- Ben Mahler


On July 13, 2015, 11:55 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36461/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 11:55 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2913
>     https://issues.apache.org/jira/browse/MESOS-2913
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Needed these abstractions for capturing specific CALLs explicitly in subsequent reviews.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gmock.hpp 0fd3f8cf06c9efd357fa7c933cc28d527855ac9a

> 
> Diff: https://reviews.apache.org/r/36461/diff/
> 
> 
> Testing
> -------
> 
> Tested in subsequent reviews.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message