mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 35752: Implemented the ERROR Event handler in the scheduler driver.
Date Wed, 15 Jul 2015 01:47:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35752/
-----------------------------------------------------------

(Updated July 15, 2015, 1:47 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Rebased, pulled out the stub handler change into:
https://reviews.apache.org/r/36493/


Summary (updated)
-----------------

Implemented the ERROR Event handler in the scheduler driver.


Bugs: MESOS-2910
    https://issues.apache.org/jira/browse/MESOS-2910


Repository: mesos


Description (updated)
-------

See above.


Diffs (updated)
-----

  src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c 
  src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f 
  src/tests/scheduler_event_call_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/35752/diff/


Testing
-------

For now, testing needs to be done via manual injection of events. I've added a new test file
for this, which will include the driver and library tests for event / call handling. We should
be able to remove these tests as all of the existing tests will later test the event/call
path.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message