mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 34136: Add ContainerImage protobuf.
Date Tue, 14 Jul 2015 21:06:03 GMT


> On June 26, 2015, 2:57 p.m., Jiang Yan Xu wrote:
> > include/mesos/mesos.proto, lines 1212-1214
> > <https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1212>
> >
> >     Is it the intention that Image type is **defined** outside MesosInfo because
DockerInfo can later reference it?
> >     
> >     Otherwise it feels more natual to define Image within MesosInfo.
> 
> Vinod Kone wrote:
>     +1 to put it inside MesosInfo.
> 
> Ian Downes wrote:
>     I wanted it to be outside MesosInfo so it could be used by other container types,
i.e., I don't see it as specific to MesosInfo, e.g., we could also support an AppcInfo which
contained an Image::APPC.

OK SGTM.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review89577
-----------------------------------------------------------


On July 11, 2015, 9:47 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34136/
> -----------------------------------------------------------
> 
> (Updated July 11, 2015, 9:47 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add ContainerImage protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 1763129da535561503e89cbd8c4a371f8553d8d6 
> 
> Diff: https://reviews.apache.org/r/34136/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message