mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 36450: Added an Address protobuf message for consistent address information.
Date Mon, 13 Jul 2015 22:08:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36450/#review91537
-----------------------------------------------------------


Thanks for doing this!
Please ping me when this gets committed (in case I miss it) and I'll update MasterInfo.
(we also need to see how it gets translated into the ZK JSON for 0.24 and update our API/Release
Notes/docs etc.)


include/mesos/mesos.proto (line 99)
<https://reviews.apache.org/r/36450/#comment144963>

    can you please take the TODO out of the javadoc (it's an implementation detail) and maybe
add a bit more detail there about usage, assumptions, etc.



include/mesos/mesos.proto (line 102)
<https://reviews.apache.org/r/36450/#comment144961>

    what happens if the hostname and the ip are both defined but don't match?
    
    hostname == "www.google.com"
    ip = "10.10.1.0"
    
    which one "wins"?
    
    Also, slightly confused by the "asymmetry" - `port` is required, but neither ip/hostname
are: one could "legally" end up with an Address which is "8080".
    
    I would much prefer to have `ip` as `required` (and, possibly, filled in with an empty
string, or a "0.0.0.0" string).



include/mesos/mesos.proto (line 110)
<https://reviews.apache.org/r/36450/#comment144965>

    personally, I don't think this belongs in an `Address` class, but I accept I don't really
know enough of how libprocess works.



include/mesos/mesos.proto (line 793)
<https://reviews.apache.org/r/36450/#comment144966>

    nit: I think you need an extra space between ; and /


- Marco Massenzio


On July 13, 2015, 5:55 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36450/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 5:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3012
>     https://issues.apache.org/jira/browse/MESOS-3012
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To make the API more consistent, we'd like to have a single message that expresses a
network address.
> 
> Also, this enables the message passing optimization in the scheduler driver when receiving
events, per MESOS-3012.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 1763129da535561503e89cbd8c4a371f8553d8d6 
>   src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d 
> 
> Diff: https://reviews.apache.org/r/36450/diff/
> 
> 
> Testing
> -------
> 
> Will add a follow up test.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message