mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 36450: Added an Address protobuf message for consistent address information.
Date Mon, 13 Jul 2015 20:18:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36450/#review91520
-----------------------------------------------------------



include/mesos/mesos.proto (lines 108 - 110)
<https://reviews.apache.org/r/36450/#comment144947>

    Why not also add an Endpoint message to capture this part? Or a URL/I?
    
    message Endpoint {
      required Address address = 1;
      optional string path = 2;
    }
    
    OR:
    
    message URL/URI {
      optional string scheme = 1;
      required Address address = 2;
      optional string path = 3;
      repeated Parameter query = 4;
      optional string fragment = 5;
    }


- Benjamin Hindman


On July 13, 2015, 5:55 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36450/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 5:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3012
>     https://issues.apache.org/jira/browse/MESOS-3012
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> To make the API more consistent, we'd like to have a single message that expresses a
network address.
> 
> Also, this enables the message passing optimization in the scheduler driver when receiving
events, per MESOS-3012.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 1763129da535561503e89cbd8c4a371f8553d8d6 
>   src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d 
> 
> Diff: https://reviews.apache.org/r/36450/diff/
> 
> 
> Testing
> -------
> 
> Will add a follow up test.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message