mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 36453: Ignored subsequent calls to 'resourceOffers' in 'ReservationTest.CompatibleCheckpointedResources' test.
Date Mon, 13 Jul 2015 20:18:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36453/
-----------------------------------------------------------

(Updated July 13, 2015, 8:18 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Changes
-------

Addressed Jie's comment.


Bugs: MESOS-3034
    https://issues.apache.org/jira/browse/MESOS-3034


Repository: mesos


Description
-------

Ignored subsequent calls to 'resourceOffers' in 'ReservationTest.CompatibleCheckpointedResources'
test.


Diffs (updated)
-----

  src/tests/reservation_tests.cpp 99bf393ed4e806dee13518cfbd2d44d740285c2c 

Diff: https://reviews.apache.org/r/36453/diff/


Testing
-------

I was able to reproduce more reliably after changing `master.allocation_interval` to `Milliseconds(1)`
and running `GTEST_FILTER="ReservationTest.CompatibleCheckpointedResources" ./bin/mesos-tests.sh
--gtest_repeat=1000`.

Ran the above command with the fix and observed that it passes.


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message