mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 36453: Ignored subsequent calls to 'resourceOffers' in 'ReservationTest.CompatibleCheckpointedResources' test.
Date Mon, 13 Jul 2015 19:37:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36453/#review91511
-----------------------------------------------------------

Ship it!



src/tests/reservation_tests.cpp (line 928)
<https://reviews.apache.org/r/36453/#comment144937>

    Please add a comment since it's not quite obvious.
    
    .WillRepeatedly(Return());        // Ignore subsequent offers.


- Jie Yu


On July 13, 2015, 7:29 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36453/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 7:29 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3034
>     https://issues.apache.org/jira/browse/MESOS-3034
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Ignored subsequent calls to 'resourceOffers' in 'ReservationTest.CompatibleCheckpointedResources'
test.
> 
> 
> Diffs
> -----
> 
>   src/tests/reservation_tests.cpp 99bf393ed4e806dee13518cfbd2d44d740285c2c 
> 
> Diff: https://reviews.apache.org/r/36453/diff/
> 
> 
> Testing
> -------
> 
> I was able to reproduce more reliably after changing `master.allocation_interval` to
`Milliseconds(1)` and running `GTEST_FILTER="ReservationTest.CompatibleCheckpointedResources"
./bin/mesos-tests.sh --gtest_repeat=1000`.
> 
> Ran the above command with the fix and observed that it passes.
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message