mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 36425: Enabling IP Discovery script
Date Mon, 13 Jul 2015 18:14:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36425/#review91496
-----------------------------------------------------------


a few fly-by general comments.


src/master/main.cpp (line 93)
<https://reviews.apache.org/r/36425/#comment144915>

    We can get rid of this , I don' think this is being used ?



src/master/main.cpp (line 191)
<https://reviews.apache.org/r/36425/#comment144913>

    s/fopen/popen



src/master/main.cpp (line 205)
<https://reviews.apache.org/r/36425/#comment144909>

    Can we align this similar to the one you have already done a few lines before ?



src/master/main.cpp (line 209)
<https://reviews.apache.org/r/36425/#comment144912>

    Can we use our already existing abstraction stringify(...) here or did it not work here
?



src/master/main.cpp (line 211)
<https://reviews.apache.org/r/36425/#comment144908>

    Can we remove the reference here ? 
    
    strings::trim(...) returns a temporary that would be destroyed at the end of the line
leaving you with a dangling reference.


- Anand Mazumdar


On July 13, 2015, 4:35 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36425/
> -----------------------------------------------------------
> 
> (Updated July 13, 2015, 4:35 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Cody Maloney.
> 
> 
> Bugs: MESOS-2902
>     https://issues.apache.org/jira/browse/MESOS-2902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Jira: MESOS-2902
> 
> It is sometimes useful to enable an external script to
> configure the IP address the Mesos Master will bind to
> on the server, where it's not desirable to set the
> --ip flag and/or a "wrapper" script is not a viable option.
> 
> This patch adds a --ip_discovery_script to point to a local
> script that will emit as its only output the IP address that
> the Master will bind to: only spaces and newlines are allowed;
> further, as we cannot use the `libprocess` sub-processing
> facilities, we cannot timeout the script, should this block
> for long times (or even forever).
> 
> This will override the --ip flag, which, even if set, will be
> ignored.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md feee5594c88112f77ce382cb3dd8628653f92d01 
>   src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 
> 
> Diff: https://reviews.apache.org/r/36425/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message