mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 34136: Add ContainerImage protobuf.
Date Sun, 12 Jul 2015 04:16:46 GMT


> On June 25, 2015, 3:32 p.m., Paul Brett wrote:
> > include/mesos/mesos.proto, line 1221
> > <https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1221>
> >
> >     Mesos info is optional, but if present can optionally contain an image?  So
what does a mesos present with a MesosInfo message with no image mean?
> 
> Vinod Kone wrote:
>     yea. why optional?
> 
> Timothy Chen wrote:
>     I think image can be optional which bypasses the image provisioning. MesosInfo potentially
will contain other information like what DockerInfo does that is MesosContainerizer specific,
so I think this API makes sense to me.

Yep, Tim's comments reflect what I'm thinking.


> On June 25, 2015, 3:32 p.m., Paul Brett wrote:
> > include/mesos/mesos.proto, line 1202
> > <https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1202>
> >
> >     Not really an id, more of a signature for the image.  Would we be better making
this optional string sha512hash to allow for the possibility that a different signature might
be used in the future?
> 
> Vinod Kone wrote:
>     i'm assuming this is because appc calls it an image id.

Correct, this reflects naming in the appc spec.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review89438
-----------------------------------------------------------


On June 22, 2015, 9:42 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34136/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 9:42 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add ContainerImage protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 8df1211165169c9595e0e6e85b5ddc404345ff70 
> 
> Diff: https://reviews.apache.org/r/34136/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message