mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aditi Dixit" <aditi9di...@gmail.com>
Subject Re: Review Request 35687: Added capabilities to state.json
Date Sat, 11 Jul 2015 14:27:08 GMT


> On July 9, 2015, 4:26 p.m., Vinod Kone wrote:
> > src/master/http.cpp, lines 124-125
> > <https://reviews.apache.org/r/35687/diff/2/?file=1003411#file1003411line124>
> >
> >     were you not able to use 'foreach' here?
> >     
> >     foreach(FrameworkInfo::Capability& capability, framework.info.capabilities())
{
> >     
> >     }

No. I think the problem is occurring because capabilities is a repeated field.


- Aditi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review91113
-----------------------------------------------------------


On July 9, 2015, 4:04 p.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35687/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Vinod Kone.
> 
> 
> Bugs: MESOS-2900
>     https://issues.apache.org/jira/browse/MESOS-2900
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added capabilities to state.json and test for the same
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 
>   src/tests/master_tests.cpp 962455cc368c6e5405599d6565660d4c3fd0fc22 
> 
> Diff: https://reviews.apache.org/r/35687/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message