mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 36402: Adding 'Accept' header in request
Date Fri, 10 Jul 2015 22:38:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review91362
-----------------------------------------------------------



3rdparty/libprocess/src/http.cpp (lines 164 - 183)
<https://reviews.apache.org/r/36402/#comment144729>

    These appear to me to be valuable information for a caller too - please move those "up"
to be the method's Doxy (javadoc) in addition to writing up the method's description.
    
    Please make sure to make them consistent with our style for comments.



3rdparty/libprocess/src/http.cpp (line 190)
<https://reviews.apache.org/r/36402/#comment144730>

    ditto



3rdparty/libprocess/src/tests/http_tests.cpp (lines 676 - 689)
<https://reviews.apache.org/r/36402/#comment144731>

    ```
    vector<string> bogusHeaders = { "test;q=0.0",
                                    "foo",
                                    "foo, test;q=0.0",
                                    "*, test;q=0.0",
                                    "*;q=0.0, foo",
                                    "\n foo",
                                    "foo,\ttest;q=0.0"};
                                    
    http::Request request;
    for (auto accept : bogusHeaders) {
      request.headers["Accept"] = accept;
      EXPECT_FALSE(request.acceptsMediaType("test").get())
    }
    ```
    Let's please make the most out of our newly-acquired C++11 abilities :)



3rdparty/libprocess/src/tests/http_tests.cpp (line 695)
<https://reviews.apache.org/r/36402/#comment144732>

    same here


- Marco Massenzio


On July 10, 2015, 8:55 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36402/
> -----------------------------------------------------------
> 
> (Updated July 10, 2015, 8:55 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone.
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Adding a method for Accept header in request + refactor of Accept-Encoding
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 72b6d27 
>   3rdparty/libprocess/src/encoder.hpp c5ff761 
>   3rdparty/libprocess/src/http.cpp d168579 
>   3rdparty/libprocess/src/tests/encoder_tests.cpp 0032137 
>   3rdparty/libprocess/src/tests/http_tests.cpp 01f243c 
> 
> Diff: https://reviews.apache.org/r/36402/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message