mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jojy Varghese" <j...@mesosphere.io>
Subject Re: Review Request 36106: cgroups: added cpuacct subsystem
Date Thu, 09 Jul 2015 20:56:18 GMT


> On July 9, 2015, 7:36 p.m., Ben Mahler wrote:
> > src/linux/cgroups.hpp, lines 438-447
> > <https://reviews.apache.org/r/36106/diff/4/?file=1000826#file1000826line438>
> >
> >     What is the plan for introducing javadoc comments? cgroups.hpp seems like a
reasonable candidate, but we should avoid inconsistent comment formatting within a file :(
> >     
> >     I'd propose commenting in the existing style, and following up by doing a javadoc
formatting sweep across the file, if you're interested. Sound good?

I was explicitly asked to do this way for now (see above reviews). I can remove it but will
be conflicting with the other reviewer.


> On July 9, 2015, 7:36 p.m., Ben Mahler wrote:
> > src/linux/cgroups.hpp, lines 450-455
> > <https://reviews.apache.org/r/36106/diff/4/?file=1000826#file1000826line450>
> >
> >     Why are we documenting the cpuacct.stat file format here? The caller should
only cares about the user and system times, not the format of the underlying file :)

I thought extra information about where that data come from will help.


> On July 9, 2015, 7:36 p.m., Ben Mahler wrote:
> > src/linux/cgroups.hpp, lines 458-466
> > <https://reviews.apache.org/r/36106/diff/4/?file=1000826#file1000826line458>
> >
> >     Are these kinds of comments providing any value?

Just for serving doxygen. Not sure what else I could have added. Sugestions are welcome.


- Jojy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review91168
-----------------------------------------------------------


On July 7, 2015, 12:26 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36106/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 12:26 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Bugs: MESOS-2961
>     https://issues.apache.org/jira/browse/MESOS-2961
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> cgroups implementation does not have a cpuacct subsystem implementation as of
> today. Adding the implementation for stat function.
> 
> Changes:
>   - added Stats class to encapsulate cpuacct.stat data
>   - added implementation for cpuacct::stats
>   - added unit tests
> 
> Jira: MESOS-2961
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 73b98317880eea3d6a2ba37ac56d1f7e3600ba94 
>   src/linux/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00 
>   src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a 
> 
> Diff: https://reviews.apache.org/r/36106/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message