mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 36360: Adding common constants for HTTP API
Date Thu, 09 Jul 2015 20:23:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/#review91178
-----------------------------------------------------------

Ship it!


LGTM, Just some minor comments.


src/common/http_constants.hpp (line 18)
<https://reviews.apache.org/r/36360/#comment144466>

    This is not a self-contained header file that we encourage everyone to build up, kindly
do #include <string> and remove the adjacent include from the cpp file.



src/common/http_constants.hpp (line 26)
<https://reviews.apache.org/r/36360/#comment144463>

    s/Supported Content-Tye and Accept headers/Supported media types for Content-Type and
Accept headers.



src/common/http_constants.cpp (line 26)
<https://reviews.apache.org/r/36360/#comment144465>

    minor nit-pick , might consider using std::string; before-hand ?


- Anand Mazumdar


On July 9, 2015, 7:58 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36360/
> -----------------------------------------------------------
> 
> (Updated July 9, 2015, 7:58 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Ben Mahler, Marco Massenzio,
and Vinod Kone.
> 
> 
> Bugs: MESOS-2860
>     https://issues.apache.org/jira/browse/MESOS-2860
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Adding constants used commonly through the different HTTP endpoints
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e5b5d36 
>   src/common/http_constants.hpp PRE-CREATION 
>   src/common/http_constants.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/36360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message