mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 36106: cgroups: added cpuacct subsystem
Date Thu, 09 Jul 2015 19:36:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36106/#review91168
-----------------------------------------------------------



src/linux/cgroups.hpp (lines 438 - 447)
<https://reviews.apache.org/r/36106/#comment144458>

    What is the plan for introducing javadoc comments? cgroups.hpp seems like a reasonable
candidate, but we should avoid inconsistent comment formatting within a file :(
    
    I'd propose commenting in the existing style, and following up by doing a javadoc formatting
sweep across the file, if you're interested. Sound good?



src/linux/cgroups.hpp (lines 450 - 455)
<https://reviews.apache.org/r/36106/#comment144457>

    Why are we documenting the cpuacct.stat file format here? The caller should only cares
about the user and system times, not the format of the underlying file :)



src/linux/cgroups.hpp (lines 458 - 466)
<https://reviews.apache.org/r/36106/#comment144456>

    Are these kinds of comments providing any value?


- Ben Mahler


On July 7, 2015, 12:26 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36106/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 12:26 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Bugs: MESOS-2961
>     https://issues.apache.org/jira/browse/MESOS-2961
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> cgroups implementation does not have a cpuacct subsystem implementation as of
> today. Adding the implementation for stat function.
> 
> Changes:
>   - added Stats class to encapsulate cpuacct.stat data
>   - added implementation for cpuacct::stats
>   - added unit tests
> 
> Jira: MESOS-2961
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 73b98317880eea3d6a2ba37ac56d1f7e3600ba94 
>   src/linux/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00 
>   src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a 
> 
> Diff: https://reviews.apache.org/r/36106/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message