mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 36318: [MESOS-2294] Add support to master for streaming subscribed events
Date Thu, 09 Jul 2015 18:49:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36318/
-----------------------------------------------------------

(Updated July 9, 2015, 6:49 p.m.)


Review request for mesos, Ben Mahler, Isabel Jimenez, Marco Massenzio, and Vinod Kone.


Changes
-------

Addressed review comments + added a fix to close the pipe upon exit. Would add a test-case
for it in a separate review when submitting the re-registration(...) change thereby testing
for failover etc.


Bugs: MESOS-2294
    https://issues.apache.org/jira/browse/MESOS-2294


Repository: mesos


Description
-------

This change lays the ground-work for the master's ability to stream events back to the client.
This review turned out a bit too large for my own liking but in a nutshell, it just takes
a subscribe request and puts a subscribed event back on the stream.

Explanation of changes:
- Made a generic FrameworkDriver interface that the master now uses to communicate with the
frameworks instead of just invoking send(framework->pid,...)
- Framework's can be of 2 types now http, libprocess.
- Made a adapter class that takes the messages from master, transforms them to events that
the http framework driver can then understand.
- This still uses hard-coded http related constants. They can go away when Isabel submits
her validation change (36217)
- This change prefers use of using trailing under-scores as member variables from the style
guide.


Diffs (updated)
-----

  src/common/protobuf_utils.hpp afe5a85d3f58eaabb16807253c5fcc07cabcf8e8 
  src/common/protobuf_utils.cpp 8a51daa45db312ca4608dda3fd99df2c3f9962f1 
  src/master/http.cpp 23a6d4bd2f60cb4a4ad463aea7cc032941578bdc 
  src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec 
  src/master/master.cpp 35e147574842e3c6ae819541a6c03bf16a375294 
  src/tests/http_api_tests.cpp 64bbeb6699171e85a5be293919ad9f32ded0ebac 

Diff: https://reviews.apache.org/r/36318/diff/


Testing
-------

make check + a simple test for subscribe call received a subscribed event back on the stream.


Thanks,

Anand Mazumdar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message