mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <>
Subject Re: Review Request 35777: Made handle bad (or not) ReviewBoard URLs.
Date Thu, 09 Jul 2015 17:07:50 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 9, 2015, 5:07 p.m.)

Review request for mesos, Benjamin Hindman, Marco Massenzio, and Till Toenshoff.


Remove unicode characters copy/pasted from `reviewboardrc` documentation.

Repository: mesos

Description (updated)

Handles the case where the ReviewBoard URL is invalid.

af081a07234794f60a2575e0383ce537d7111c18 - Fixed hanging bug. (29 seconds

Invalid ReviewBoard URL : ' abcd'

Reads `REVIEWBOARD_URL` from `.reviewboardrc` if it's available. We use `imp.load_source`
to import the `.reviewboardrc` file.
> __.reviewboardrc__
> The .reviewboardrc file is a generic place for configuring a repository. This must be
in a directory in the user's checkout path to work. __It must parse as a valid Python file__,
or you'll see an error when using rbt.


  support/ b04e26b85e6b056098c15078f9b31dc352682351 



Modified the commit message with `git rebase` and ran `./support/` to observe
the above error messages.
Used the valid commit message for this patch and created it by running `./support/`.


Michael Park

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message